[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] RE: [patch][vtd] Remove ASSERT in hvmloader.c whenassigning disk controller to a guest


  • To: "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Zhang, Li" <li.zhang@xxxxxxxxx>
  • Date: Fri, 27 Jun 2008 09:34:35 +0800
  • Delivery-date: Thu, 26 Jun 2008 18:35:07 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcjWta1A49gT7Ps4RHaMe8nse4Bn7gAAVCFqAAYNOIAAAHUk0AAAUdjHAEfbHFA=
  • Thread-topic: [Xen-devel] RE: [patch][vtd] Remove ASSERT in hvmloader.c whenassigning disk controller to a guest

Add 'if (vendor == 0x8086)' is better. If using IDE Controller from
other vendors, add the corresponding condition. Here the guest should
not crash. So send the patch again. Sorry for troubling.
Thanks 

>  -----Original Message-----
>  From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
>  Sent: Wednesday, June 25, 2008 10:47 PM
>  To: Zhang, Li; xen-devel@xxxxxxxxxxxxxxxxxxx
>  Subject: Re: [Xen-devel] RE: [patch][vtd] Remove ASSERT in
hvmloader.c
>  whenassigning disk controller to a guest
>  
>  On 25/6/08 15:38, "Zhang, Li" <li.zhang@xxxxxxxxx> wrote:
>  
>  >>  If the device is not PIIX3 IDE, we also should do the two
>  > pci_writew().
>  >>  The 0x40 and 0x42 are timing registers of IDE0 and IDE1, and they
are
>  >>  used to enable the IDE command decoding function.
>  >>  And from the PIIX3, ICH to ICH10, the IDE timing registers
addresses
>  > are
>  >>  the same. So I think removing the ASSERT is OK. The original
comment
>  > in
>  >>  the file is a little puzzling.
>  
>  So the registers exist in all *Intel* chipsets that we care about.
What
>  about other vendors? Should we make the pci_writew() invocations
conditional
>  on vendor_id==0x8086?
>  
>   -- Keir
>  

Attachment: hvmloader.patch
Description: hvmloader.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.