[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] please revert c/s 17686

On 13/6/08 08:45, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>> Will you keep the 10ms tick in this case? If that's acceptable it should be
>> a simple patch.
> I think it would be nice it the tick was enabled only when at least one
> CPU actually is about to enter or in C3. And I'm not certain whether
> it wouldn't be possible to use a larger value than 10ms - at least in the
> case where all CPUs are in C3 (but I see that this case doesn't really
> seem to be expected anyway, given the warning handle_hpet_broadcast()
> generates when the current CPU is in the channel's mask; I'm also
> unclear about how the warning is avoided when the CPU currently in
> charge of handling the timer interrupt is to enter C3 - maybe I'm
> overlooking a place where the affinity get changed).

I missed that warning printk. It does indeed look odd.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.