[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] [HVM] fix tracing for 64bit guests

  • To: Andre Przywara <andre.przywara@xxxxxxx>
  • From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • Date: Tue, 10 Jun 2008 10:27:09 +0100
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 10 Jun 2008 02:28:37 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcjK3CfVZlrifTbPEd2k+wAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH] [HVM] fix tracing for 64bit guests

On 10/6/08 09:53, "Andre Przywara" <andre.przywara@xxxxxxx> wrote:

> This basically will always log 64bit values for the instruction pointer.
> I thought about this approach, too, but didn't do it because I got the
> impression that trace files are large enough and with the recently
> introduced 'variable number of parameters' saving disk space is a concern.
> Do you want to promote other pointers to always 64bit, too? Shall I
> prepare a patch for this?

My opinion is if it's efficient enough for 64-bit guests then it must be
good enough for 32-bit guests too. Further, I don't want extra usually
unnecessary checks on the common vmentry/vmexit paths, and always using the
64-bit version reduces code clutter.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.