[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [Patch] XendOptionsSMF, missing get_config_value method on Solaris

John Levon wrote:
> On Fri, Jun 06, 2008 at 02:57:13PM +0200, Juergen Keil wrote:
> > On Solaris, xend XendOptions.py uses an additional interface XendOptionsSMF.
> > This allows xend configuration via Solaris SMF as well as the config file.
> > (Added by changeset 13407).
> > 
> > Problem: XendOptionsSMF doesn't define a get_config_value; but these
> > is get_config_string.  The code in XendOptions.py needs both; 
> > get_keymap() needs get_config_value.
> I'm not sure about this: SMF values are always typed and there's really
> no such thing as just a value. Instead, I think get_keymap() needs to
> use get_config_string(). Note it's the only base class routine that does
> this.

Ok, changing the base class to use get_config_string instead of 
of get_config_value would be another way to fix this.

> Note it's the only base class routine that does this.

In xen-unstable, there also is get_resource_label_change_script().

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.