[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/4] rombios interface for HVM S3

  • To: Juergen Keil <jk@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • Date: Mon, 02 Jun 2008 15:14:10 +0100
  • Delivery-date: Mon, 02 Jun 2008 07:14:51 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcjEuu0LK5MxIjCuEd2v7AAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH 3/4] rombios interface for HVM S3

On 2/6/08 14:45, "Juergen Keil" <jk@xxxxxxxx> wrote:

> For unknown reasons, HVM S3 resume hangs in the bios when trying to load
> the x_firmware_waking_vector from absolute address 0xEA01C (it hangs for
> access to address 0x10000, but doesn't hang for 0xfffe).

It works on Intel because there we emulate the rombios, and our emulator
does not bother with segment limit checks in real mode. This is actually
more lenient than real hardware, hence an AMD CPU (which is directly
executing the rombios code) will fault on the access because it is at a
segment offset greater than 64kB.

Your patch is good. Please re-submit with a fixed changeset comment and a
signed-off-by line. I'll then check it in.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.