[Xen-devel] Re: [PATCH] VT-d: IOTLB flush fixups

["Yang, Xiaowei" <xiaowei.yang@xxxxxxxxx>]

On Wed, 2008-05-28 at 23:00 +0800, Espen Skoglund wrote:

> Oh, right.  When flushing a non-present cached entry domid 0 must be
> used.  Here's a modification of your patch:
> 
>  - Made the non-present flush testing a bit simpler.
>  - Removed dma_addr_level_page_maddr().  Use a modified
>    addr_to_dma_page_maddr() instead.
Yes, it's simpler. Thanks! However, you forgot spin_unlock before
return. so it leads to deadlock. Here's a small fix.

>  - Upon mapping new context entry: flush old entry using domid 0 and
>    always flush iotlb.
Actually, you may find before/after your modification, the code are the
same functionally. We can pass domid=0 or non_present_entry_flush=1 to
flush non present tlb.

Thanks,
Xiaowei
>

Attachment: spin.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel