[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen


  • To: "Liu, Jinsong" <jinsong.liu@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • Date: Tue, 13 May 2008 09:55:51 +0100
  • Delivery-date: Tue, 13 May 2008 01:56:28 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Aci0pum5DchKJJryTjCAyBnEoEeG2AAMDsoT
  • Thread-topic: [Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen

On 13/5/08 04:10, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:

> Get ACPI Px from dom0 and chose Px controller
> 
> Add platform op hypercall case to get ACPI Px info from dom0.
> Chose Px controller from dom0 (cpufreq=dom0-kernel)
> or hypervisor (cpufreq=xen-cpufreq)

No gcc-specific attributes in the public header files. This means no
__attribute__((packed)). Please fix that.

Also why declare a local variable 'a' in your changes to common/domain.c?

 -- Keir




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.