[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH] AMD IOMMU: Hanlde sibling device assignment correctly


  • To: Wei Wang2 <wei.wang2@xxxxxxx>
  • From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • Date: Wed, 07 May 2008 10:53:52 +0100
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 07 May 2008 02:54:27 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AciwKEFAgAC+xxwbEd2RFwAX8io7RQ==
  • Thread-topic: [PATCH] AMD IOMMU: Hanlde sibling device assignment correctly



On 7/5/08 10:27, "Wei Wang2" <wei.wang2@xxxxxxx> wrote:

> Devices on AMD IOMMU system share a same set of IO page tables if they
> are indexed by a same device ID in device table. To prevent these
> sibling devices from being assigned to different domains, a successful
> device assignment requires all sibling devices are owned by  either
> pciback or the target domain. This is a trial patch with minor
> modifications in the common interface to handle this situation
> correctly.  VTD code has also been slightly touched please let me know
> if it breaks any VTD functionality. Thanks!

This patch seems to do more than you suggest, for example adding an extra
iommu hook into setup.c for dom0. Also it does get_domain_by_id() with no
corresponding put_domain(). And in fact you should be able to
rcu_lock_domain_by_id()/rcu_unlock_domain() instead which is faster.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.