Re: [Xen-devel] [PATCH] Fix deadlock in schedule.c at TRACE mode

[Atsushi SAKAI <sakaia@xxxxxxxxxxxxxx>]

Hi, Naoki

I have two questions about this.

1)How to reproduce your deadlock ?
  Would you give me your test environment to reproduce this deadlock?
  Is it easily reproduced by running xenmon.py or xentrace 
  with one or two guest domain(s)?
　or Any additional condition needed?

2)About fixing code,
  I think __trace_var() should fix for this issue not schedule()
  This issue cannot be fixed by modify the __trace_var()?

Thanks
Atsushi SAKAI


NISHIGUCHI Naoki <nisiguti@xxxxxxxxxxxxxx> wrote:

> Hi,
> 
> In schedule.c, schedule() and sched_adjust() call trace functions during
> acquiring lock of schedule_lock in each cpu's schedule_data. When trace
> buffers are enabled, the trace function (__trace_var()) may call
> vcpu_wake() by calling send_guest_global_virq(). In the case, a deadlock
> occurs when acquiring lock of schedule_lock.
> 
> Attached patch fixes this problem.
> 
> Signed-off-by: Naoki Nishiguchi <nisiguti@xxxxxxxxxxxxxx>
> 
> Regards,
> Naoki Nishiguchi



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel