[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] AMD IOMMU: Defer IO pagetable construction until device assignment


  • To: Wei Wang2 <wei.wang2@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • Date: Wed, 02 Apr 2008 15:52:07 +0100
  • Delivery-date: Wed, 02 Apr 2008 07:53:34 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AciU0R8LXYkYlADEEd2zswAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH] AMD IOMMU: Defer IO pagetable construction until device assignment

On 2/4/08 15:13, "Wei Wang2" <wei.wang2@xxxxxxx> wrote:

> During HVM domain creation, I/O page tables are filled by coping p2m
> entries from p2m table, which is a useless step for non-passthru domain.
> This patch defers I/O page table construction until the moment of device
> assignment. In case that pci devices are never assigned or hot plugged,
> the unnecessary duplication will be avoid.

You can't duplicate p2m_lock() and p2m_unlock(). Why do you need to protect
your new function with that lock anyway?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.