Re: [Xen-devel] [RFC][PATCH] Use ioemu block drivers through blktap

[Kevin Wolf <kwolf@xxxxxxx>]

Ian Jackson schrieb:
> Yes, but to avoid gradually accumulating an ever increasing amount of
> cruft, that cleanup mechanism ought to be capable of cleaning up even
> `lost' garbage of one kind or another.  And once you've got such a
> garbage collecting cleanup arrangement, you don't need any separate
> atexit-like arrangement which cleans up specifically after the current
> run.

Well then, feel free to implement it. ;-)

> It is best just to run the garbage collector at a suitable point.  Do
> you have a garbage collector which deletes pipes from stale domains ?

Not directly, no. When a domain gets the same domain ID, the pipe is
reused and then freed when the domain is destroyed. But you don't want
to reboot your Dom0 too often, so you won't get the same domain ID too
early...

> OTOH if you write special-case code like this then you have the costs
> of writing extra code.  Code costs effort to maintain and typically
> has a nonzero bug rate, causing actual problems when it goes wrong.

If you think we were better off just dropping this code, for my part we
can do so. I just thought I'd port also the shutdown handlers from
tapdisk while I'm at it.

Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel