Re: [Xen-devel] grant tables and HVM+PV

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 28/3/08 16:50, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:

> Has broken our HVM PV drivers. Previously we were using:
> 
> 520         if ((HYPERVISOR_grant_table_op(GNTTABOP_setup_table, pset, 1) !=
> 0) ||
> 521             (pset->status != 0)) {
> 
> even on HVM. Now, this isn't actually necessary (stuff works fine with
> the call nop'd out, presumably due to the auto-sizing), but I wonder why the
> only grant op allowed is _query_size? IE what's the status of grant
> table code on HVM/PV? Is it just disabled because no compat audit has
> been done, or what?

Most of the mapping calls wouldn't work at all. Query_size() could probably
be simply given a stub implementation for HVM that returns all is good.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel