[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] unnamed union structure members are dangerous to expose in public headers


  • To: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • Date: Tue, 25 Mar 2008 17:33:53 +0000
  • Delivery-date: Tue, 25 Mar 2008 10:35:21 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AciOnmT3o1akkvqREdyTBAAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH] unnamed union structure members are dangerous to expose in public headers

On 25/3/08 17:25, "Samuel Thibault" <samuel.thibault@xxxxxxxxxxxxx> wrote:

> will return 0x13e0 when compiled without gcc -std=c99, while the
> expected value is 0x1430, resulting to seg faults and all kinds of
> tricks.  Compiling with
> 
> #include "/usr/include/xen/foreign/x86_64.h"
> 
> shows why:
> 
> /usr/include/xen/foreign/x86_64.h:88: warning: declaration does not
> declare anything

This raises two obvious questions:
 1. Why building with -std=c99?
 2. Why building without -Werror?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.