[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] Schedule shutdown fix



domain_shutdown() needs to call raise_softirq(SCHEDULE_SOFTIRQ).
This forces the current vcpu to be rescheduled and paused.
Without this, during live migrate, if another vcpu has defer_shutdown==1
then the current vcpu can return from domain_shutdown(),
do a vmenter, and continue running guest code, "resume" code that
should only be running on the receiving node!

Signed-off-by: Robert Phillips <rphillips@xxxxxxxxxxxxxxx>
Signed-off-by: Ben Guthro <bguthro@xxxxxxxxxxxxxxx>
diff -r 4674efa621d4 xen/common/domain.c
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -415,6 +415,7 @@ void domain_shutdown(struct domain *d, u
     __domain_finalise_shutdown(d);
 
     spin_unlock(&d->shutdown_lock);
+    raise_softirq(SCHEDULE_SOFTIRQ);
 }
 
 void domain_resume(struct domain *d)
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.