Re: [Xen-devel] [Patch 4/4] Accelerated network drivers

[Kieran Mansley <kmansley@xxxxxxxxxxxxxx>]

On Tue, 2008-02-19 at 09:25 +0000, Kieran Mansley wrote:
> On Mon, 2008-02-18 at 14:37 -0800, Kurt Hackel wrote:
> > Hi,
> > 
> > Looks like this patch (linux-2.6.18-xen.hg 423:af0d925ba938) is
> > causing a build failure.
> >
> > Did you mean to add -Idrivers/net/sfc/sfc_resource or
> > -Idrivers/xen/sfc_netback to drivers/xen/sfc_netback/Makefile?
> > 
> 
> >From your errors it would certainly look like adding -
> Idrivers/xen/sfc_netback would fix it.  What I don't yet understand is
> why I've never seen this problem.  I'll investigate and sort out a
> patch.

I'm still not sure why I've not seen this failure: a clean checkout and
build has no problems for me, but the change should be harmless so I've
attached a patch that should solve your problem.

Signed-off-by Kieran Mansley <kmansley@xxxxxxxxxxxxxx>

Thanks

Kieran

Add -I. to sfc module builds

diff -r 9dea529497fe drivers/net/sfc/sfc_resource/Makefile
--- a/drivers/net/sfc/sfc_resource/Makefile
+++ b/drivers/net/sfc/sfc_resource/Makefile
@@ -3,7 +3,7 @@ EXTRA_CFLAGS += -D__CI_HARDWARE_CONFIG_F
 EXTRA_CFLAGS += -D__CI_HARDWARE_CONFIG_FALCON__
 EXTRA_CFLAGS += -D__ci_driver__ 
 EXTRA_CFLAGS += -Werror
-EXTRA_CFLAGS += -Idrivers/net/sfc
+EXTRA_CFLAGS += -Idrivers/net/sfc -Idrivers/net/sfc/sfc_resource
 
 sfc_resource-objs := resource_driver.o iopage.o efx_vi_shm.o \
        driverlink_new.o kernel_proc.o kfifo.o \
diff -r 9dea529497fe drivers/xen/sfc_netback/Makefile
--- a/drivers/xen/sfc_netback/Makefile
+++ b/drivers/xen/sfc_netback/Makefile
@@ -1,4 +1,4 @@ EXTRA_CFLAGS += -Idrivers/xen/sfc_netuti
-EXTRA_CFLAGS += -Idrivers/xen/sfc_netutil -Idrivers/xen/netback 
-Idrivers/net/sfc
+EXTRA_CFLAGS += -Idrivers/xen/sfc_netback -Idrivers/xen/sfc_netutil 
-Idrivers/xen/netback -Idrivers/net/sfc
 EXTRA_CFLAGS += -D__ci_driver__ 
 EXTRA_CFLAGS += -DEFX_USE_KCOMPAT
 EXTRA_CFLAGS += -Werror
diff -r 9dea529497fe drivers/xen/sfc_netfront/Makefile
--- a/drivers/xen/sfc_netfront/Makefile
+++ b/drivers/xen/sfc_netfront/Makefile
@@ -1,4 +1,4 @@ EXTRA_CFLAGS += -Idrivers/xen/sfc_netuti
-EXTRA_CFLAGS += -Idrivers/xen/sfc_netutil -Idrivers/xen/netfront
+EXTRA_CFLAGS += -Idrivers/xen/sfc_netfront -Idrivers/xen/sfc_netutil 
-Idrivers/xen/netfront
 EXTRA_CFLAGS += -D__ci_driver__
 EXTRA_CFLAGS += -Werror
 
diff -r 9dea529497fe drivers/xen/sfc_netutil/Makefile
--- a/drivers/xen/sfc_netutil/Makefile
+++ b/drivers/xen/sfc_netutil/Makefile
@@ -1,3 +1,4 @@ EXTRA_CFLAGS += -Werror
+EXTRA_CFLAGS += -Idrivers/xen/sfc_netutil
 EXTRA_CFLAGS += -Werror
 
 ifdef GGOV

Attachment: sfc_module_includes
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel