[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH] hvm: Fix APIC-ID cpuid intercept


  • To: Andre Przywara <andre.przywara@xxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Thu, 07 Feb 2008 08:19:48 +0000
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 07 Feb 2008 00:19:31 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AchpYjP9coPYqtVVEdymTgAWy6hiGQ==
  • Thread-topic: [PATCH] hvm: Fix APIC-ID cpuid intercept

On 6/2/08 22:44, "Andre Przywara" <andre.przywara@xxxxxxx> wrote:

> the HVM CPUID intercept does not mask out the local APIC ID bits in
> CPUID Fn0000_0001, bits 24-31 in EBX. This results in inconsistent
> values of subsequent calls to cpuid on the same VCPU (delivering the
> value of the physical CPU), depending on the current scheduling. This
> for instance confuses Linux' NUMA code.
> The attached patch fixes this by replacing the physical APIC ID with the
> VCPU number, both in the VMX and SVM branches.
> 
> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
> 
> I hope this does not trigger any side effects...

I'm sure it can't do worse than the current broken behaviour!

 Thanks,
 Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.