RE: [Xen-devel] [PATCH] Simplify paging_invlpg when flush is notrequired.

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

>From: Keir Fraser
>Sent: 2008年2月3日 16:56
>
>Is there a significant advantage to doing this? One other 
>comment is that I
>don't like extra boolean 0/1 arguments to functions. I'd rather have
>something like paging_invlpg() and paging_invlpg_noflush() and 
>only have the
>boolean argument to paging.mode->invlpg().
>
> -- Keir

No significant advantage, and just eye-balled this redundant work.
Here's updated version. Only check compilation this time.

----

Simplify paging_invlpg when flush is not required.

Add paging_invlpg_noflush, when flush check is not required.
It's wasteful to always validate shadow linear mapping if
caller doesn't check return value at all.

Signed-off-by Kevin Tian <kevin.tian@xxxxxxxxx>

Thanks,
Kevin

Attachment: invlpg.patch
Description: invlpg.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel