Re: [Xen-devel] [PATCH] Fix xenconsole's "Could not read tty from store"

[John Levon <levon@xxxxxxxxxxxxxxxxx>]

On Mon, Dec 17, 2007 at 11:22:54AM +0000, Samuel Thibault wrote:

> I was getting intermittent "Could not read tty from store" when creating
> domains. This is because tools/console/daemon/io.c:domain_create_tty()
> seems to expect openpty() to initiaze term, but it's the converse:
> openpty expects to be given term parameters and doesn't touch it, so
> that term mostly contains random data when given to tcsetattr, and thus
> console creation failure. Here is a patch that fixes this.

I already sent out a patch for this very code to the list for testing
last week. Please can I get some testing of that patch??

It'll need merging with Samuel's patch I suppose. Note that we don't see
his problem on Solaris as the openpty() implementation above gets the
semantics wrong and we get away with it.

> +     if (tcgetattr(master, &term) < 0) {
> +             err = errno;

Please use the slave not the master. It doesn't matter on Linux but it's
critical on Solaris.

If it helps I can send out an updated patch merging these fixes. Will
you test it if so Samuel?

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel