[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Duplicate __HYPERVISOR_grant_table_op in hvm_hypercall32_table?


  • To: Paul Samon <paul.samon@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Thu, 13 Dec 2007 11:04:49 +0000
  • Delivery-date: Thu, 13 Dec 2007 02:58:33 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acg9d/pPOKKMlalrEdy4+wAWy6hiGQ==
  • Thread-topic: [Xen-devel] Duplicate __HYPERVISOR_grant_table_op in hvm_hypercall32_table?

The assignment of do_grant_table_op() is bogus. I’ll remove it.

 Thanks,
 Keir


On 13/12/07 10:23, "Paul Samon" <paul.samon@xxxxxxxxx> wrote:

In xen/arch/x86/hvm/hvm.c:
#define HYPERCALL(x)                                        \
    [ __HYPERVISOR_ ## x ] = (hvm_hypercall_t *) do_ ## x
 
#if defined(__i386__)
 
static hvm_hypercall_t *hvm_hypercall32_table[NR_hypercalls] = {
    HYPERCALL(memory_op),
    [ __HYPERVISOR_grant_table_op ] = (hvm_hypercall_t *)hvm_grant_table_op,
    HYPERCALL(xen_version),
    HYPERCALL(grant_table_op),
    HYPERCALL(event_channel_op),
    HYPERCALL(sched_op),
    HYPERCALL(hvm_op)
};
 
#else /* defined(__x86_64__) */
-------------------
For the index __HYPERVISOR_grant_table_op, there are 2 assignments -- do_grant_table_op(), and hvm_grant_table_op() here???
What's the purpose by doing so?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.