[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] tools/firmware/hvmloader/smbios.c::hvm_write_smbios_tables()


  • To: Jun Koi <junkoi2004@xxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Fri, 07 Dec 2007 08:55:06 +0000
  • Cc: "List: Xen Developers" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 07 Dec 2007 00:49:39 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acg4rtzNGz8R0KSiEdyEtQAWy6hiGQ==
  • Thread-topic: [Xen-devel] tools/firmware/hvmloader/smbios.c::hvm_write_smbios_tables()

On 7/12/07 08:47, "Jun Koi" <junkoi2004@xxxxxxxxx> wrote:

>>> Basically, these long code can be written in only 1 line, like this:
>>> 
>>> snprintf(xen_version_str, sizeof(xen_version_str), "%u.%u%s",
>>> xen_major_version, xen_minor_version, xen_extra_verison);
>> 
>> There is no snprintf() in hvmloader currently.
>> 
> 
> Hmmm... can't we include stdio.h for it? It is userspace code anyway, no?

No, it's guest firmware.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.