[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] [QEMU-DM] Upgrade emulated UART to 16550A.


  • To: Trolle Selander <trolle.selander@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Wed, 05 Dec 2007 13:55:20 +0000
  • Delivery-date: Wed, 05 Dec 2007 05:56:17 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acg3Rnkot3JV8qM5Edyv/QAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH] [QEMU-DM] Upgrade emulated UART to 16550A.

Please email me a signed-off-by line:
Signed-off-by: Trolle Selander <trolle.selander@xxxxxxxxx>

You can see the Developer’s Certificate of Origin at:
http://old.linux-foundation.org/newsroom/press_releases/2004/2004_05_24_dco.html
...which is what you are certifying by providing the signed-off-by attribution for your patches.

 -- Keir

On 4/12/07 16:32, "Trolle Selander" <trolle.selander@xxxxxxxxx> wrote:

This patch adds 16550 emulation to qemu-dm. I still consider it a work in progress, but from my testing, it consistently performs better than the old code already, sometimes considerably so (on my laptop, dumping out data over serial from a HVM DomU -> pty in Dom0 was up to 5.3 times faster than with the old 16450 code). I can consistenly reach full 115200 baud speeds over physical serial lines when the virtual device is backed by a phys port, which I never could with the old code.

There are still some things to be done. I want to add proper error handling, so that overflow/framing & parity errors on the physical port get detected and reported by the virtual port. Also, now that FIFOs are in place, I believe performance could be improved significantly by putting some code into the hypervisor so that reads & writes from the FIFOs don't have to exit into qemu-dm at all. I'm also reading up on the specs for newer uarts with deeper FIFOs.

However, for now, I think this patch is already quite good, and I don't think I should sit on it any longer. I'm looking forward to hearing what results others will get with it.

It applies on top of my previously posted patch for modem status/control line passthrough, so I'm re-posting that patch here as well to make things easier.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.