Re: [Xen-devel] Re: xsm: Consolidate xsm processing within domain control hypercall.

["George S. Coker, II" <gscoker@xxxxxxxxxxxxxx>]

On 12/4/07 4:52 PM, "Alex Williamson" <alex.williamson@xxxxxx> wrote:

> 
> On Tue, 2007-12-04 at 16:36 -0500, Mike D. Day wrote:
>> On 04/12/07 13:44 -0700, Alex Williamson wrote:
>>> 
>>> On Tue, 2007-12-04 at 13:06 -0700, Alex Williamson wrote:
>>>> Does this work right across a PV domain save/restore on x86?  On ia64
>>>> I end up with "Domain-Unnamed" after I save a PV domain and another
>>>> after I restore it, then do a shutdown.  Reverting this patch restores
>>>> correct behavior.  Thanks,
>>> 
>>>    This also doesn't look like it builds with XSM_ENABLE=y
>>>  Alex -- Alex Williamson HP Open Source & Linux Org.
>> 
>> It builds, if you like I'll send you a build log.
> 
>    Hmm, I'm not sure how.  Fails for me as shown below (x86_64).  Does
> x86 have the save/restore issue I mentioned?  Thanks,
> 

This is because the Flask module has not been updated for this change.
While I believe it will build with XSM_ENABLE=y with no security module
selected, the resulting binary will segfault on boot when the xsm_init
routines register the dummy module and reach a NULL dereference for the
unimplemented domctl hook.

> Alex
> 
> cset 16519:62451388f630
> $ make XSM_ENABLE=y FLASK_ENABLE=y xen
> ...
> gcc -O2 -fomit-frame-pointer -m64 -DNDEBUG -fno-strict-aliasing
> -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value
> -Wdeclaration-after-statement -DVMXASSIST -nostdinc -fno-builtin
> -fno-common -iwithprefix include -Werror -Wno-pointer-arith -pipe
> -I/tmp/test/xen/include -I/tmp/test/xen/include/asm-x86/mach-generic
> -I/tmp/test/xen/include/asm-x86/mach-default -msoft-float
> -fno-stack-protector -mno-red-zone -fpic -fno-reorder-blocks
> -fno-asynchronous-unwind-tables -DGCC_HAS_VISIBILITY_ATTRIBUTE -g
> -D__XEN__ -DXSM_ENABLE -DFLASK_ENABLE -DXSM_MAGIC=0xf97cff8c
> -DFLASK_DEVELOP -DFLASK_BOOTPARAM -DFLASK_AVC_STATS -c domctl.c -o
> domctl.o
> In file included from domctl.c:27:
> /tmp/test/xen/include/xsm/xsm.h: In function ?xsm_getdomaininfo¹:
> /tmp/test/xen/include/xsm/xsm.h:148: error: ?struct xsm_operations¹ has
> no member named ?domain_getdomaininfo¹
> make[4]: *** [domctl.o] Error 1
> make[4]: Leaving directory `/tmp/test/xen/common'
> make[3]: *** [/tmp/test/xen/common/built_in.o] Error 2
> make[3]: Leaving directory `/tmp/test/xen/arch/x86'
> make[2]: *** [/tmp/test/xen/xen] Error 2
> make[2]: Leaving directory `/tmp/test/xen'
> make[1]: *** [install] Error 2
> make[1]: Leaving directory `/tmp/test/xen'
> make: *** [install-xen] Error 2

-- 
George S. Coker, II <gscoker@xxxxxxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel