[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH][HVM] Fix 2 type mismatches in vlapic.h andhpet.c for 32-bit build Xen


  • To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, "xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
  • Date: Tue, 27 Nov 2007 12:01:45 +0800
  • Delivery-date: Mon, 26 Nov 2007 20:04:31 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcgwqGajcxL9lyZSSkG/2aFRcODxtwAAYgZA
  • Thread-topic: [Xen-devel] [PATCH][HVM] Fix 2 type mismatches in vlapic.h andhpet.c for 32-bit build Xen

Cui, Dexuan wrote:
> For 32-bit build of Xen,
> 1) the first mismatch (in hpet_read(), length is 4)  makes guest think
> the HPET DM is buggy (we return 0 for HPET_CFG.COUNTER_CLK_PERIOD to
> guest), so guest wouldn't use HPET at all.
> 2) the second one: if tmict is 62500000 and timer_divisor is 16
> (Fedora7's installer uses the values at some time), 10 * 62500000 *
> 16 = 0x2540BE400 -- it's too big to be held in uint32_t.
> 
> Signed-off-by: Dexuan Cui <dexuan.cui@xxxxxxxxx>

Please use this new patch.
The first patch omits one other place in vlapic.c :)

-- Dexuan

Attachment: fix_type_mismatch_for_32bit_xen.patch
Description: fix_type_mismatch_for_32bit_xen.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.