[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] Initialize last_error in libxc



Hi,

When I tested some xm commands, I saw the following unjust error messages. 

# xm vcpu-pin vm1 0 99
Error: Cannot pin vcpu: 0 to cpu: [99] - (2865808, 'Unknown error code', 
'\x90\xba+')
Usage: xm vcpu-pin <Domain> <VCPU|all> <CPUs|all>

Set which CPUs a VCPU can use.
# xm trigger vm1 INIT
Error: (2865808, 'Unknown error code', '\x90\xba+')
Usage: xm trigger <Domain> <nmi|reset|init> [<VCPU>]

Send a trigger to a domain.


I think that the cause is because _xc_get_last_error() in libxc does not 
initialize last_error. 
This patch initializes last_error.  The test result is as follows. 

# xm vcpu-pin vm1 0 99
Error: Cannot pin vcpu: 0 to cpu: [99] - (22, 'Invalid argument')
Usage: xm vcpu-pin <Domain> <VCPU|all> <CPUs|all>

Set which CPUs a VCPU can use.
# xm trigger vm1 INIT
Error: (38, 'Function not implemented')
Usage: xm trigger <Domain> <nmi|reset|init> [<VCPU>]

Send a trigger to a domain.


Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

Best regards,
 Kan

Attachment: initialize_last_error.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.