[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] [hotplug scripts] Unlock the 'block' lock before bailing out when no loop device can be found


  • To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Stefan Berger <stefanb@xxxxxxxxxx>
  • Date: Wed, 03 Oct 2007 14:17:43 -0400
  • Delivery-date: Wed, 03 Oct 2007 11:10:29 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Unlock the 'block' lock before bailing out when no available loop device
can be found. If this is not done the lock is not given up and results
in xend's response time becoming very slow.

I'd recommend applying the patch to the 3.1 testing tree as well.

        if [ "$loopdev" = '' ]
        then
--> missing release lock here!
          fatal 'Failed to find an unused loop device'
--> never gets here since fatal leaves with 'exit 1'
        fi

        do_or_die losetup "$loopdev" "$file"
        xenstore_write "$XENBUS_PATH/node" "$loopdev"
        write_dev "$loopdev"
        release_lock "block"
        exit 0


Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>

Attachment: release_lock_on_fatal_in_block.diff
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.