Re: [Xen-devel] [PATCH][HVM] fix migration from NX-capable machine to non-NX-capable machine

["Dave Lively" <dlively@xxxxxxxxxxxxxxx>]

On 9/28/07, Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> wrote:
> On 27/9/07 22:12, "David Lively" <dlively@xxxxxxxxxxxxxxx> wrote:
> > +    u64 efer_mask = EFER_SCE || (cpu_has_nx ? EFER_NX : 0);
>
> Wrong kind of OR?

Ack.  Yes, thank you.  It was "working" because EFER_SCE == 1, so
efer_mask was always 1, but this meant I was never propagating EFER_NX
....  I'll retest with '|' and get back to you.

> As for AMD, are there any SVM CPUs that do not also support NX?

I saw this bug on an Intel CPU that supported NX -- it was just
disabled in the BIOS.  I'll be speaking with some AMD folks later this
morning, so I'll ask whether the same thing is possible w/AMD SVM.

Dave

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel