[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [VTD][patch 1/1] vt-d hardware check


  • To: "Kay, Allen M" <allen.m.kay@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Sat, 22 Sep 2007 07:20:40 +0100
  • Delivery-date: Fri, 21 Sep 2007 23:16:35 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acf8qK+aNrR/pFLgS56NLFji8eoZKQAOALU5
  • Thread-topic: [Xen-devel] [VTD][patch 1/1] vt-d hardware check

vtd_hw_check() clears vtd_enabled and returns ENODEV, so the caller should
be:

 if (!vtd_enabled)
    return -ENODEV;
 rc = vtd_hw_check();
 if ( rc )
    return rc;

Note that the above code skips acpi_dmar_init() entirely if !vtd_enabled.
This behaviour is different from your patch but I think more sensible?

 -- Keir

On 22/9/07 00:39, "Kay, Allen M" <allen.m.kay@xxxxxxxxx> wrote:

> This patch disables vt-d for old chipset steppings that does not have
> compatible CPU compatible vt-d page table format.
> 
> Signed-off-by: Allen Kay <allen.m.kay@xxxxxxxxx>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.