[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH][ELF] Correct space calculation for symtab when BSD_SYMTAB=yes


  • To: Christoph Egger <Christoph.Egger@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Thu, 02 Aug 2007 14:21:34 +0100
  • Delivery-date: Thu, 02 Aug 2007 06:19:23 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcfVCAvuSjtWCUD7Edy3iQAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH][ELF] Correct space calculation for symtab when BSD_SYMTAB=yes

On 2/8/07 13:26, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

>> What do the virtual addresses of the symtab/strtab sections have to
>> do with their location in the final address space, after loading? And since
>> you pack the sections into the domain address space in
>> elf_xen_dom_load_binary(), should you not simply sum the sizes of the
>> sections, then sstart=virt_kend and send=sstart+size_sum, rather than
>> taking max(end addresses in elf image) minus min(start addresses in elf
>> image).
> 
> You're right. Attached is a patch, which does it that way.

Please try changeset 15679 in the -unstable staging tree. It's less code and
also fixed up to work with the domU domain builder too. Except it's not
actually been tested with a bsd_symtab guest kernel. It shouldn't need more
than a few lines of fixing to get it working though, if that.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.