[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] [PVFB] Fix shift key for graphical vnc display



Hi All,

There is a problem in the input of the key in the VNC connection on the PV domain.
When client's keyboard is not the same as the kind of the keyboard of PVFB
and GuestOS, it is not possible to input it correctly.

This patch handled the state of shift from the set keymap.
When client's keyboard is not same as the kind of PVFB/GuestOS,
it is possible to input it correctly.
It was confirmed to input it correctly mutually with this patch between en-us
and ja.

Signed-off-by: Takanori Kasai <kasai.takanori@xxxxxxxxxxxxxx>

Best Regards,

--
Takanori Kasai


----- Original Message ----- From: "Kasai Takanori" <kasai.takanori@xxxxxxxxxxxxxx>
To: "xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Sent: Friday, July 20, 2007 6:45 PM
Subject: [Xen-devel] [PATCH] [IOEMU] Fix shift key for graphical vnc display


Hi All,

There is a problem in the input of the key in the VNC connection on the HVM
domain.
When client's keyboard is not the same as the kind of the keyboard of qemu-dm
and GuestOS, it is not possible to input it correctly.

  VNC client     qemu-dm & GuestOS
--------------+-----------------------
   ja             en-us               ==> NG
   en-us          en-us               ==> OK

Originally, the same keysym-code between client and qemu-dm is transmitted.
However, even if it is the same character, the state of shift is different
according to the kind of keyboard.

ex.
  "=" charactor
---------------------
en-us :  "="
ja    :  shift + "-"

Therefore, it is necessary to handle the state of the shift by setting
qemu-dm and GuestOS. There is information on whether shift is necessary
for each key for the keymap of qemu-dm.

ex.
VNC client        : ja
qemu-dm & GuestOS : en-us
input key         : "="
event client to qemu-dm :
 shift(push) >> "="(push) >> "="(release) >> shift(release)
event qemu-dm to guest :
 shift(push) >> shift(release) >> "="(push) >> "="(release) >> shift(push) >>
shift(release)

This patch handled the state of shift from the set keymap.
When client's keyboard is not same as the kind of qemu-dm/GuestOS,
it is possible to input it correctly.
It was confirmed to input it correctly mutually with this patch between en-us
and ja.

Signed-off-by: Takanori Kasai <kasai.takanori@xxxxxxxxxxxxxx>

Best Regards,

--
Takanori Kasai

Attachment: fix-vncfb-shift-key.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.