RE: [Xen-devel] Will hap_alloc fail?

[Mats Petersson <mats@xxxxxxxxxxxxxxxxx>]

At 18:14 12/07/2007, Huang2, Wei wrote:
> Tim Deegan wrote:
> > At 11:34 -0500 on 12 Jul (1184240066), Huang2, Wei wrote:
> >> How does this fix sound?
> >
> > I think we need somaething that crashes just the guest in question --
> > this patch just replaces a probable pagefault crash with an explicit
> > BUG().
>
> Do you think domain_crash() work here? Or you want some way to propagate
> error information from hap_alloc() to upper levels?
Note: I'm not speaking on behalf of ANYONE here.

I would have thought that domain_crash() is the right thing to do - 
there's nothing "better" that can be done elsewhere, as far as I can 
understand, and there's really no point in propagating an error 
unless there's something that can be done about it (or it can be 
ignored, which isn't the case in this instance), as this only leads 
to potential misses of the propagated error, making it harder to debug.
--
Mats


> Thanks,
>
> -Wei
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel