Re: [Xen-devel] [PATCH 4/4] [XEND] add scsihost interface

[Tomonari Horikoshi <t.horikoshi@xxxxxxxxxxxxxx>]

Hi Kanno-san.

Thanks for your comment.

I send the patch of corrected Xend. 


Best regards,
Tomonari Horikoshi


Masaki Kanno wrote:----------------------
Sent:    Sun, 15 Jul 2007 13:34:36 +0900
Subject: Re: [Xen-devel] [PATCH 4/4] [XEND] add scsihost interface

> Hi Tomonari,
> 
> I have two comments. 
> 
> XendDevices.py:
> @@ -36,6 +36,7 @@ class XendDevices:
>  
>      controllers = {
>          'vbd': blkif.BlkifController,
> +     'scsihost': scsihostif.SCSIHostController,
>          'vif': netif.NetifController,
>          'vtpm': tpmif.TPMifController,
>          'pci': pciif.PciController,
> 
> The added line includes a tab.
> 
> 
> main.py:
> @@ -2213,6 +2262,10 @@ def xm_block_detach(args):
>          except:
>              pass
>          detach(args, 'tap')
> +
> +def xm_scsihost_detach(args):
> +    arg_check(args, "xm_scsihost_detach", 2, 3)
> +    detach(args, 'scsihost-detach', 'scsihost')
>  
>  def xm_network_detach(args):
>      if serverType == SERVER_XEN_API:
> 
> The number of argument of detach() is two. 
> 'scsihost-detach' is unnecessary. 
> 
> 
> Best regards,
>  Kan
> 
> >
> >[PATCH 4/4] [XEND] add scsihost interface
> >
> >
> >Best regards,
> >Tomonari Horikoshi
> >
> >
> >-------------------------------text/plain-------------------------------
> >_______________________________________________
> >Xen-devel mailing list
> >Xen-devel@xxxxxxxxxxxxxxxxxxx
> >http://lists.xensource.com/xen-devel

Attachment: xend_scsihost.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel