[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/12] Add suspend/resume to devices owned by Xen


  • To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Mon, 11 Jun 2007 11:42:59 +0100
  • Delivery-date: Mon, 11 Jun 2007 03:41:09 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AceW+19nrz3vWNtATFekqBOc/y2imQVFRs2KAAACwLAAATBdpg==
  • Thread-topic: [Xen-devel] [PATCH 1/12] Add suspend/resume to devices owned by Xen

On 11/6/07 11:12, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:

>> Is this correct? I think you should either increment wc_sec by sleep_diff,
>> *or* increment stime by SECONDS(sleep_diff). If you do both, wall clock
>> will
>> jump by twice the amount it should have done, won't it (because wc_sec
>> is
>> wallclock time when stime=0)?
>> 
>> -- Keir
> 
> You're right that wc_sec shouldn't be updated. I have a patch pending
> in house to fix it actually, but wait for right time to submit. :-) Thanks for
> review and sorry for no notification earlier.

I should have your first patch in today. Slow progress. :-) But I'm cleaning
up the time stuff first, and I suspect some of the subsequent patches will
merge in more quickly.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.