Re: [Xen-ia64-devel] Re: [Xen-devel] [RFC][PATCH] "Controller" pcibackend and frontend extensions

[Alex Williamson <alex.williamson@xxxxxx>]

On Sun, 2007-06-10 at 20:13 +0100, Keir Fraser wrote:
> On 10/6/07 19:24, "Alex Williamson" <alex.williamson@xxxxxx> wrote:
> 
> >    I would like to see this backend become the default backend for ia64,
> > but it probably needs testing on other systems before we can make the
> > switch.  I would appreciate testing and/or review feedback.  To make use
> > of extended I/O port spaces, you'll need the patch I sent to
> > xen-ia64-devel last week to register the I/O port spaces with Xen.

Hi Keir,

   Thanks for looking at the patch.

> It would be nice to have just one backend type, with relevant bits of its
> code made arch-specific. I'm sure x86 doesn't need vpci, passthru *and*
> slot.

  I agree, but I wasn't ready to tackle that problem.

> This is probably fine for now; it doesn't preclude merging or dropping other
> backends down the line. Only thing I spotted is that you make an enormous
> inline function in pcifront.h. That function will have to be moved elsewhere
> into a .c file if it's getting that big.

   Right, I forgot about that.  It is rather unwieldy for a static
inline.  I guess pcifront/pci_op.c is the most appropriate place for it.
I'll tuck it in a #ifdef there unless you have a better suggestion.
Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel