Re: [Xen-devel] PATCH: Add persistent guest & hv logging in xenconsoled

[Keir Fraser <keir@xxxxxxxxxxxxx>]

On 31/5/07 22:32, "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote:

>   * Adds a --pid-file command line argument to override the default
>     location of pid file (this is not really related to logging, but
>     since i was in that code...)

Applied, thanks. But...

Use of uninitialised local variable pidfile detected by gcc in this patch.
You guys really should consider using -Werror. It's great. :-)

Also, shouldn't the writes to log files be non-blocking, and those fds be
added to the select set when there is data waiting to be written?

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel