[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] PATCH: Add persistent guest & hv logging in xenconsoled


  • To: "Daniel P. Berrange" <berrange@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Mon, 04 Jun 2007 14:48:25 +0100
  • Delivery-date: Mon, 04 Jun 2007 06:46:36 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcemrwXKRKPCXhKiEdyEowAX8io7RQ==
  • Thread-topic: [Xen-devel] PATCH: Add persistent guest & hv logging in xenconsoled

On 31/5/07 22:32, "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote:

>   * Adds a --pid-file command line argument to override the default
>     location of pid file (this is not really related to logging, but
>     since i was in that code...)

Applied, thanks. But...

Use of uninitialised local variable pidfile detected by gcc in this patch.
You guys really should consider using -Werror. It's great. :-)

Also, shouldn't the writes to log files be non-blocking, and those fds be
added to the select set when there is data waiting to be written?

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.