[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] [xm] Fix vncdisplay for hvm guests

Keir Fraser wrote:

On 16/5/07 00:14, "Jim Fehlig" <jfehlig@xxxxxxxxxx> wrote:

results in '-vncunused' being passed to qemu-dm.  There are several
for a fix - this patch defaults vncdisplay to None in xm options.  It
currently defaults to 1 and is always included in the image config
created by configure_hvm() in tools/python/xen/xm/create.py.  In xend
(tools/python/xen/xend/image.py - parseDeviceModelArgs), vncunused takes
precedence over vncdisplay.

Looks like it changes vncunused default rather than vncdisplay. Wouldn't the
preferred default be to keep vncunused=1?

Sorry, the wording was a little off in the original post. Right, it does change vncunused to None - not vncdisplay. But the patch was against 3.1.0 and the logic in parseDeviceModelArgs has changed between 3.1.0 and current unstable. In unstable it looks as though vncunused will not be default if it _and_ vncdisplay are not set - which is the case in 3.1.0.

Further, I did not verify the default behavior for pv domains if neither vncunused or vncdisplay is set :-/. I will verify behavior of vncunused vs vncdisplay in unstable and repost patch if necessary.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.