[Xen-devel] Re: [PATCH 3/4] [Net] Support Xen accelerated network plugin modules

[Stephen Hemminger <shemminger@xxxxxxxxxxxxxxxxxxxx>]

On Fri, 18 May 2007 14:16:48 +0100
Kieran Mansley <kmansley@xxxxxxxxxxxxxx> wrote:

> Add support to Xen netfront for accelerated plugin module
> 
>
> 
> +/*
> + * List of all netfront accelerator plugin modules available.  Each
> + * list entry is of type struct netfront_accelerator.
> + */ 
> +static struct list_head accelerators_list;
> +/*
> + * Lock to protect access to accelerators_list, and also used to
> + * protect the hooks_usecount field in struct netfront_accelerator
> + * against concurrent access 
> + */
> +static spinlock_t accelerators_lock;
> +


Your locking model is more complex than it needs to be.
If you just used RCU for access, and depended on the existing RT netlink
mutex (a.k.a big network lock), for setup; then you wouldn't need to
do any of your own locking.

-- 
Stephen Hemminger <shemminger@xxxxxxxxxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel