[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] new_ctxt_format in xc_linux_restore?

On 21/5/07 06:37, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:

> Guess following lines as typo since new context format is used to
> support fast suspend with online vcpu context saved in image file:
> if ( !new_ctxt_format ) <--- Opposite should be used here???
>     ctxt.flags |= VGCF_online;
> Or do I misunderstand save/restore logic? Also interested why
> smp restore works if a true typo above. :-)

It's the right way round. Old images may not include the VGCF_online flag
(since it is a new flag). Since old images only ever include one saved VCPU,
and that VCPU is never offline, we just poke that flag in.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.