[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] Fix write parameter masking for 32-bit guests.

  • To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
  • Date: Sun, 13 May 2007 15:49:22 +0800
  • Cc: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Delivery-date: Sun, 13 May 2007 00:47:48 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AceVMzhKOfboKd4hQNKFfDAIGnB8iA==
  • Thread-topic: [PATCH] Fix write parameter masking for 32-bit guests.

Changeset 15046:e527b4ff1948 breaks 32-bit HVM guest: when req->size is
4, "1UL << 32" returns 1 in IA32 system, so the mask becomes 0 wrongly.
The attached patch fixes this by using 64-bit left-shift.

Signed-off-by: Dexuan Cui <dexuan.cui@xxxxxxxxx>

Attachment: helper2.c.patch
Description: helper2.c.patch

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.