[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Is patches/linux-2.6.18/xen-hotplug.patch still necessary?

  • To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
  • From: "Dave Lively" <dave.lively@xxxxxxxxx>
  • Date: Wed, 9 May 2007 09:52:05 -0400
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxx>
  • Delivery-date: Wed, 09 May 2007 06:50:29 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=kZEZGTaCw3Yc30iMJECU7LBGoAigRzXwa0sabGbqdhQ9lvwNtNEIv2rzgBAw8nFOmW65yrlO5YCH2bNKB2gj1K4csSlqryNljqzc8pvGFI9JJTKuiw0vpIWKoqdKpwEbL/lOzEh7NYFJxYVNJmf0c2ywY0jh2tHGkLQzWoaxLwg=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

I made 'top' deal with CPU hotplug a couple years ago, and submitted
the changes to the 'procps' maintainers, who never got back to me.
I've given the patch to a number of external folks (in particular,
some from the OSDL hotplug SIG), so it may have found its way into
some versions of 'top'.  In any case, I'll try to track down the
current status and dig up those patches Real Soon Now.

Dave Lively
Virtual Iron

On 5/9/07, Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> wrote:
On 8/5/07 23:26, "Alex Williamson" <alex.williamson@xxxxxx> wrote:

>    Is the patch below, that's currently in the Xen tree, still
> necessary?  The original commit comment indicates this is so things like
> 'top' don't get upset during CPU hotplugs.  But should that be handled
> by the hotplug infrastructure in the kernel (or top itself)?

It has to be handled in top itself. With some versions at least it was the
case that top would crash when CPUs where hot-unplugged. If you revert that
patch, does your version of top work okay in the hot-unplug case (you have
to run top across the unplug operation to see if it will crash or not)?

 -- Keir

Xen-devel mailing list

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.