[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel][Xense-devel][PATCH][2/4] Xen Securtiy Modules: FLASK

Hi George,

More coding style nits from my automated pedantry script.

> Updates in this patch set include:
>     - reintroduction of rcu locking support in security cache
>     - track xsm changes
> Signed-off-by: George Coker <gscoker@xxxxxxxxxxxxxx>

I've not attached the style checker output this one gave me because most of 
it's fairly homogeneous can be fixed by a regexp find/replace.  Issues 

Most Xen code spaces out the if conditional brackets like so:
    if ( !node_ptr )
if boolean operators are used in the expression they're also surrounded by 
space.  There are a number of places where Linux-style spacing is used 

Braces are always on their own line in the Xen code...  There are a number of 
places where this patch puts them on a line with another statement, K&R / 
Linux style.

I also found a number of instances of trailing whitespace, and of tabs being 
used for indentation instead of spaces.

All these things can probably be fixed using sed / emacs / etc so I've not 
attached the rather verbose output from the checker...  Please let me know if 
I can help speed things up and I'll send you more information.


Dave: Just a question. What use is a unicyle with no seat?  And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.