[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Re: [PATCH] [ACM] Comilation fix for 32 bit




xen-devel-bounces@xxxxxxxxxxxxxxxxxxx wrote on 04/26/2007 02:50:49 AM:

> On 26/4/07 04:36, "Stefan Berger" <stefanb@xxxxxxxxxx> wrote:
>
> > This fixes a compilation problem on 32 bit machines.
> >
> > Signed-off-by: Stefan Berger
>
> What's the issue?


It does not compile on 32bit because of those 4 lines. 64bit is fine.

>
> You're better off keeping the GUEST_HANDLE_64() and getting rid of the
> compat acm stuff. As far as I can see, all your interfaces are *currently*
> 32/64-bit invariant. So the compat stuff can safely be removed and then you
> don't need to continually keep it sync.


I was going to ask you about this. I am writing on a patch that puts all the ACM hypercall structures into a union. I am wondering what the compat stuff is for (xen/common/compat) and what the criterion is for needing this compat code.

   Stefan

>
>  -- Keir
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.