[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Should Qemu monitor be enabled by default


  • To: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
  • From: "Christian Limpach" <christian.limpach@xxxxxxxxx>
  • Date: Thu, 12 Apr 2007 21:40:26 +0100
  • Cc: Atsushi SAKAI <sakaia@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, "You, Yongkang" <yongkang.you@xxxxxxxxx>, ?????? <kouya@xxxxxxxxxxxxxx>
  • Delivery-date: Thu, 12 Apr 2007 13:39:15 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=lU/yg8TRjrXqBZGW6m1Og/PHMM0T2nBr1my67pWZnkJ5GiJRL3zE/8EQ7sPoTO3ViKp/zgDp5mJvbqlrK6MVKuRS5SJmU3+YaHpW1W+N8WrX6FVdFAVrAj0HAdu15JsTyyGMHfeEQm06GfwSf7UFqUkzdjynZ4wyKy/kvmCqGBg=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On 4/12/07, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote:
This part of the patch does not look correct:

-- a/tools/python/xen/xend/image.py     Thu Apr 12 13:18:08 2007 +0100
+++ b/tools/python/xen/xend/image.py    Thu Apr 12 13:21:26 2007 +0100
@@ -415,6 +415,8 @@ class HVMImageHandler(ImageHandler):
         else:
             ret.append('-nographic')

+        if int(vmConfig['platform'].get('monitor', 0)) != 0:
+            ret.append('-monitor vc')
         return ret

     def createDeviceModel(self, restore = False):

The '-monitor vc' is already the default for QEMU, so both branches of
that if end up reducing to the same functional state - the monitor being
enabled. You need to explicitly disable the monitor if the config file
has monitor=0

No, the monitor in qemu is off by default, the patch is correct as is.

I'm not sure this patch is a good idea long term though. If, as Anthony
suggests in previous thread, XenD takes control of the monitor and provides
an explicit 'xm monitor' command, then it'll be impossible to also make
the monitor also appear on a VC.

This also doesn't address the issue that making the monitor appear on a
VC is fundamentally a security risk and so can never be enabled in any
production environment where you care about integrity of the Dom0 host.
I don't see the point in introducing a config file setting which will
have to go away once a sustainable 'xm monitor' patch is implemented.

Why shouldn't both co-exist?  You can have either monitor=pty or
monitor=vc.  This is how serial ports work already.

For the timescales involved in 3.0.5 I think we should instead make sure
that 'xm block-configure' works correctly.

How does it not work correctly?

    christian

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.