[Xen-devel] Re: [patch 23/26] Xen-paravirt_ops: Add Xen grant table support

[Ingo Molnar <mingo@xxxxxxx>]

* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

> Add Xen 'grant table' driver which allows granting of access to 
> selected local memory pages by other virtual machines and, 
> symmetrically, the mapping of remote memory pages which other virtual 
> machines have granted access to.
> 
> This driver is a prerequisite for many of the Xen virtual device 
> drivers, which grant the 'device driver domain' restricted and 
> temporary access to only those memory pages that are currently 
> involved in I/O operations.

> +
> +#ifndef __ia64__
> +     {

introduce a proper arch method instead.

> +     unsigned long flags;
> +     int ref;
> +     grant_ref_t head;
> +     spin_lock_irqsave(&gnttab_list_lock, flags);

> +     unsigned long flags;
> +     spin_lock_irqsave(&gnttab_list_lock, flags);

> +     unsigned long flags;
> +     int count = 1;
> +     if (head == GNTTAB_LIST_END)

> +     grant_ref_t g = *private_head;
> +     if (unlikely(g == GNTTAB_LIST_END))

coding style problems.

        Ingo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel