Re: [Xen-devel] mini-os: C programming

[Keir Fraser <keir@xxxxxxxxxxxxx>]

On 15/3/07 13:39, "PUCCETTI Armand" <armand.puccetti@xxxxxx> wrote:

> extern char *stack;

Yes, this one is bogus.

> 2. In file xen-3.0.3/extras/mini-os/gnttab.c:140: the const variable
> gnttabop_error_msgs
> is declared as
> 
> static const char *gnttabop_error_msgs[] = GNTTABOP_error_msgs;
> 
> shouldn't that instead be declared:
> 
> static const char * const gnttabop_error_msgs[] = GNTTABOP_error_msgs;

It doesn't really matter, does it? Personally I hate scattering 'const' all
over the place.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel