[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Re: [Xen-changelog] [xen-unstable] linux: Fix xenbus device write function.


  • To: John Levon <levon@xxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Thu, 08 Mar 2007 07:52:28 +0000
  • Delivery-date: Wed, 07 Mar 2007 23:51:02 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcdhVret9lrQ981JEduPKQAWy6hiGQ==
  • Thread-topic: [Xen-devel] Re: [Xen-changelog] [xen-unstable] linux: Fix xenbus device write function.



On 7/3/07 19:48, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:

>> u->len += len;
>> - if (u->len < (sizeof(u->u.msg) + u->u.msg.len))
>> -  return len;
>> + if ((u->len < sizeof(u->u.msg)) ||
>> +     (u->len < (sizeof(u->u.msg) + u->u.msg.len)))
>> +  return rc;
> 
> What is this trying to achieve?

Check you have a complete header before comparing on the header's length
field.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.