RE: [Xen-devel] hvm_init_ap_contexts

["Petersson, Mats" <Mats.Petersson@xxxxxxx>]

> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of 
> Keir Fraser
> Sent: 01 March 2007 17:00
> To: PUCCETTI Armand; xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] hvm_init_ap_contexts
> 
> The return keyword is pointless here, but allowed.

Agreed - but removing the return keyword would make sure that someone
looking at the code doesn't try to figure out what is being returned by
the original function - and since there's nothing being returned, not
using a return keyword makes the code "clearer". 

My personal opinion, of course. 

--
Mats
> 
>  -- Keir
> 
> On 1/3/07 16:42, "PUCCETTI Armand" <armand.puccetti@xxxxxx> wrote:
> 
> > Why is there an argument returned in the function below (of hvm.h),
> > knowing that there is void?
> > 
> > static inline void
> > hvm_init_ap_context(struct vcpu_guest_context *ctxt,
> >                    int vcpuid, int trampoline_vector)
> > {
> >    return hvm_funcs.init_ap_context(ctxt, vcpuid, 
> trampoline_vector);
> > }
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
> 
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel