RE: [Xen-devel] Re: [Patch] the interface of invalidating qemu mapcache

["Cui, Dexuan" <dexuan.cui@xxxxxxxxx>]

Keir,
Attached is the latest version of the patch.
Thanks very much for your comments!

 -- Dexuan

>-----Original Message-----
>From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
>Sent: 2007年1月27日 18:41
>To: Cui, Dexuan; Li, Xin B; xen-devel@xxxxxxxxxxxxxxxxxxx
>Subject: Re: [Xen-devel] Re: [Patch] the interface of invalidating qemu 
>mapcache
>
>On 27/1/07 10:29 am, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx> wrote:
>
>> Keir,
>> Attached is the updated version. The exported qemu_invalidate_map_cache() 
>> just
>> blows the entire qemu mapcache.
>> Would you please give some comments? Thanks a lot!
>
>Allocating the PCI resources with an incrementing region_num counter is
>pointless (and in fact confusing) given that the BAR for mmio and portio
>resources are hardcoded as 1 and 0 (respectively) in the pv-on-hvm driver
>code. Also the existing portio resource is (I believe) a placeholder. Thus
>you don't need to create a new resource -- use the first port of resource
>region 0 instead. The existing read/write handler registrations in
>platform_io_map() are pointless. You can remove them and replace with a
>single-byte write handler to blow the mapcache -- there's no need to install
>handlers for 2- or 4-byte accesses, nor for read accesses.
>
> -- Keir

Attachment: interface_of_invalidating_qemu_mapcache-3.diff
Description: interface_of_invalidating_qemu_mapcache-3.diff

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel