Re: [Xen-devel] [PATCH 7/8] HVM save restore: shadow fix

[Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>]

At 22:12 +0800 on 11 Jan (1168553551), Zhai, Edwin wrote:
> [PATCH 7/8] HVM save restore: shadow fix
> 
> Signed-off-by: Zhai Edwin <edwin.zhai@xxxxxxxxx>
> 
> fix 2 shadow issues:
> * restored guest's mem type_info are not correct

In what way?  And why are you fixing that in the shadow
pagetable-promotion path rather than the restore path?  
If the pagetable pages are wrong, are other pages wrong too?

> +    {
> +        struct page_info *page = mfn_to_page(gmfn);
> +        /* XXX: add it to emulate a touched page */
> +        if ((page->u.inuse.type_info & PGT_type_mask) == PGT_none){
> +            page->u.inuse.type_info |= (PGT_writable_page | PGT_validated);
> +        }
> +    }
> +

Should this be gated to only happen to HVM guests?

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel