Re: [PATCH][RFC] dump-core: PFN-GMFN table and ELF formatify (was Re: [Xen-devel] xc_get_pfn_list() creates broken core files)

[John Levon <levon@xxxxxxxxxxxxxxxxx>]

On Mon, Jan 15, 2007 at 06:16:47PM +0900, Isaku Yamahata wrote:

> I added PFN-GMFN table to xen dump format and made it ELF format
> based on John's patch. This patch isn't complete yet.

You use LINUX for the OSABI, which doesn't seem right.

I'm not clear why these are all program headers instead of sections.
Given the slightly odd nature of this file, I would expect it to have no
phdrs, or at most one phdr for the page array (and plus a section
header). Same goes for notes - those would seem more useful as a
section per type of thing (e.g. a .XEN_vcpu_context section, etc.). And
that way you get the "what is this section's size" and "how big are the
entries" for free.

But before all this, most importantly, I'd like all interested parties
to sit down and design (and document!) the exact contents of the ELF
format first, especially considering the needs of HVM and save/migration
format. It doesn't make sense to me to start coding until we at least
have a good idea of what we need in the new format.

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel