[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] ptwr_emulate adjustments

  • To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Tue, 16 Jan 2007 12:58:47 +0000
  • Delivery-date: Tue, 16 Jan 2007 04:58:41 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acc5bg9YTcwLI6VhEdurKQANk04WTA==
  • Thread-topic: [Xen-devel] [PATCH] ptwr_emulate adjustments

On 16/1/07 12:40 pm, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> - really only do the invalid PAE PTE fixup on write to the high part

Okay. We could theoretically get failures the other way round too I should
think but clearly the existing code doesn't handle that properly (since
it'll lose the PAGE_PRESENT forever) so it can't be something we've seen in
practise. This clarification and extra check makes sense.

> - dump guest execution state when emulation fails

We can't put anything more than XENLOG_G_WARNING on a path that a guest can
exercise at will. One option is to make show_execution_state (and hence all
underlying state-dump functions) take the dump log level as a parameter.

> - use the passed in register pointer rather than re-calculating
>   guest_cpu_user_regs()

The assertion is broken and anyway really a bit overkill imo. Using regs
rather than guest_cpu_user_regs() makes sense.

 -- Keir

> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.